Add switch_host submodule#3
Conversation
|
Elliot, Can you update your commit message to provide a brief description of what the commit is before? This guide from the Erlang folks is a good summary of how to structure a useful commit message. "A List Apart" has a slightly longer article that says pretty much the same thing. |
|
My bad, I figured since I had discussed this with Gagan I wouldn't need to explain as much. |
|
@betaredex Instead of copying config.py_SAMPLE to config.py, I think it can be imported directly in switch_host.py as "import config.py_SAMPLE as cfg". Also, we will have to follow the naming convention and rename config.py_SAMPLE as switch_config.py. And then we need to add the line *config.py to the .gitignore file to avoid uploading it accidentally. @larsks I know you don't want to be involved in the website development :) But can you please give your opinion on this? |
@gagansk , (a) I don't understand the context for your comment, because the files you are discussing are not part of this pull request, and (b) That's not valid syntax (you import modules, not files, so if you had a file named (c) Without seeing the code involved I'm just making stuff up, but it sounds like a bad idea to try importing something with "sample" or "example' in the name (because it's not really a sample, then, it's actual configuration that you're using). |
No description provided.